Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Key Vault] TypeSpec for Certificates library #28708

Merged
merged 63 commits into from
Jan 16, 2025
Merged

[Key Vault] TypeSpec for Certificates library #28708

merged 63 commits into from
Jan 16, 2025

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Apr 16, 2024 •
edited
Loading

Data Plane API - Pull Request

This spec is for the KV Certificates library, and has been successfully tested with Python end-to-end (Azure/azure-sdk-for-python#36903).

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Checks stuck in `queued` state? If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.

@mccoyp mccoyp added KeyVault TypeSpec Authored with TypeSpec labels Apr 16, 2024
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 16, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 16, 2024 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand] 
Validation passes for LintDiff.
Compared specs (v2.2.2) new version base version
default default(a325c2b) default(main)
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 16, 2024 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 5be6c323ca60dbd16e9823b2f4815cf35bfa46dd. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[automation_init.sh] npm notice
cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
cmderr	[automation_init.sh] npm notice
warn		specification/keyvault/data-plane/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 16, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/security/keyvault/azcertificates There is no API change compared with the previous version
Python azure-keyvault-certificates https://apiview.dev/Assemblies/Review/b2fdced96a5343cc972aac842b5f43fc?revisionId=d0ebbe69e600462bbd13534d00ad0249
TypeSpec Security.KeyVault.Certificates https://apiview.dev/Assemblies/Review/0529655b61bc404ebd37d2d5192ba45a?revisionId=93b4975767ea4130b9f4c2b1de688326

@mccoyp mccoyp force-pushed the mccoyp/kv-typespec branch from 88ccbdb to 0cc1739 Compare May 14, 2024 23:46
catalinaperalta
catalinaperalta reviewed May 16, 2024
View reviewed changes
This was referenced May 28, 2024
Merged
Merged
@mccoyp mccoyp marked this pull request as ready for review June 3, 2024 22:45
@mccoyp mccoyp requested review from heaths and jlichwa as code owners June 3, 2024 22:45
@mccoyp mccoyp requested a review from johanste June 3, 2024 22:46
heaths
heaths requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed all the code, but this is also in the wrong directory. See #29249 (review) for more info about the state and lack of review on this one.

@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Jun 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Jul 15, 2024
@timovv timovv mentioned this pull request Jul 18, 2024
Closed
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Aug 5, 2024
@mccoyp mccoyp mentioned this pull request Aug 15, 2024
Merged
6 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Sep 2, 2024
@mccoyp mccoyp removed the no-recent-activity There has been no recent activity on this issue. label Sep 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Sep 23, 2024
mccoyp and others added 18 commits January 16, 2025 11:44
@heaths
Copy link
Member

heaths commented Jan 16, 2025

I reviewed suppressions and they were all in service of migration consistency.

@heaths
Copy link
Member

heaths commented Jan 16, 2025

@mccoyp can you resolve the conflict quick? Then this is good to go.

@mccoyp
Copy link
Member Author

mccoyp commented Jan 16, 2025

Yep, resolving now -- cSpell.json was just removed in #32171

@mccoyp mccoyp force-pushed the mccoyp/kv-typespec branch from bde57be to 645acc8 Compare January 16, 2025 19:51
@mccoyp mccoyp requested a review from cheathamb36 as a code owner January 16, 2025 19:51
@mccoyp mccoyp merged commit fcba952 into main Jan 16, 2025
27 of 29 checks passed
@mccoyp mccoyp deleted the mccoyp/kv-typespec branch January 16, 2025 20:13
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Feb 6, 2025
@mccoyp @markcowl
[Key Vault] TypeSpec for Certificates library (Azure#28708)
dd87981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

@RickWinter RickWinter RickWinter left review comments

@catalinaperalta catalinaperalta catalinaperalta left review comments

@jhendrixMSFT jhendrixMSFT jhendrixMSFT left review comments

@johanste johanste johanste approved these changes

@jlichwa jlichwa Awaiting requested review from jlichwa

@chlowell chlowell Awaiting requested review from chlowell

@chen-karen chen-karen Awaiting requested review from chen-karen chen-karen is a code owner

@lgonsoulin lgonsoulin Awaiting requested review from lgonsoulin lgonsoulin is a code owner

@vickm vickm Awaiting requested review from vickm vickm is a code owner

@cheathamb36 cheathamb36 Awaiting requested review from cheathamb36 cheathamb36 is a code owner

Assignees
No one assigned
Labels
Approved-Suppression BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane KeyVault PublishToCustomers Acknowledgement the changes will be published to Azure customers. SuppressionReviewRequired TypeSpec Authored with TypeSpec
Projects
Azure SDK for Key Vault
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.